fix: prevent extra iterations occurring on getRunIdAndUrl

Codex- · Codex- · commit b838ffdeeb24 · 2024-10-26T13:09:41.000+13:00
diff --git a/src/return-dispatch.spec.ts b/src/return-dispatch.spec.ts
@@ -779,7 +779,7 @@ describe("return-dispatch", () => {
 
         const getRunIdAndUrlPromise = getRunIdAndUrl({
           ...defaultOpts,
-          workflowTimeoutMs: 10 * 1000,
+          workflowTimeoutMs: 15 * 1000,
         });
 
         // First attempt
diff --git a/src/return-dispatch.ts b/src/return-dispatch.ts
@@ -146,7 +146,6 @@ export async function getRunIdAndUrl({
   let elapsedTime = Date.now() - startTime;
   while (elapsedTime < workflowTimeoutMs) {
     attemptNo++;
-    elapsedTime = Date.now() - startTime;
 
     // Get all runs for a given workflow ID
     const fetchWorkflowRunIds = await api.retryOrTimeout(
@@ -180,6 +179,7 @@ export async function getRunIdAndUrl({
     }
 
     await sleep(constants.WORKFLOW_JOB_STEPS_RETRY_MS);
+    elapsedTime = Date.now() - startTime;
   }
 
   return { success: false, reason: "timeout" };

Original file line number	Diff line number	Diff line change
`@@ -146,7 +146,6 @@ export async function getRunIdAndUrl({`
`146`	`146`	`let elapsedTime = Date.now() - startTime;`
`147`	`147`	`while (elapsedTime < workflowTimeoutMs) {`
`148`	`148`	`attemptNo++;`
`149`		`- elapsedTime = Date.now() - startTime;`
`150`	`149`
`151`	`150`	`// Get all runs for a given workflow ID`
`152`	`151`	`const fetchWorkflowRunIds = await api.retryOrTimeout(`
`@@ -180,6 +179,7 @@ export async function getRunIdAndUrl({`
`180`	`179`	`}`
`181`	`180`
`182`	`181`	`await sleep(constants.WORKFLOW_JOB_STEPS_RETRY_MS);`
	`182`	`+ elapsedTime = Date.now() - startTime;`
`183`	`183`	`}`
`184`	`184`
`185`	`185`	`return { success: false, reason: "timeout" };`