Fix PanelSyncManger using the wrong method in getOrCreateSyncHandler()#174
Merged
brachy84 merged 1 commit intoCleanroomMC:masterfrom Nov 17, 2025
Merged
Conversation
use class cast method instead of raw casting
brachy84
approved these changes
Nov 17, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previously,
getSyncHandler()ingetOrCreateSyncHandler()was called with just the name part of the map key, meaning it will never find the right sync handler and always create a new one.Otherwise if you do pass in the map key to
nameand it can't find the sync handler, you end up syncing the new sync handler with the int id attached twice, giving it the wrong map key.also uses the class
cast()method to remove those unchecked suppressions