fix: changed DefaultValues namespace to Frozen

Author: jerome.fayot

Documentation/Contributors/CodingGuide/README.md

@@ -453,15 +453,15 @@ Cartesian3.fromRadians = function (longitude, latitude, height) {
 this._mapProjection = options.mapProjection ?? new GeographicProjection();
 ```
 
-- If an `options` parameter is optional and never modified afterwards, use `DefaultValues.EMPTY_OBJECT` or `DefaultValues.EMPTY_ARRAY`, this could prevent from unnecessary memory allocations in code critical path, e.g.,
+- If an `options` parameter is optional and never modified afterwards, use `Frozen.EMPTY_OBJECT` or `Frozen.EMPTY_ARRAY`, this could prevent from unnecessary memory allocations in code critical path, e.g.,
 
 ```javascript
 function BaseLayerPickerViewModel(options) {
-  options = options ?? DefaultValues.EMPTY_OBJECT;
+  options = options ?? Frozen.EMPTY_OBJECT;
 
   const globe = options.globe;
   const imageryProviderViewModels =
-    options.imageryProviderViewModels ?? DefaultValues.EMPTY_ARRAY;
+    options.imageryProviderViewModels ?? Frozen.EMPTY_ARRAY;
   // ...
 }
 ```

Specs/Cesium3DTilesTester.js

@@ -1,7 +1,7 @@
 import {
   Cartesian3,
   Color,
-  DefaultValues,
+  Frozen,
   defined,
   JulianDate,
   ImageBasedLighting,
@@ -164,7 +164,7 @@ Cesium3DTilesTester.tileDestroys = function (scene, url, options) {
 
 Cesium3DTilesTester.generateBatchedTileBuffer = function (options) {
   // Procedurally generate the tile array buffer for testing purposes
-  options = options ?? DefaultValues.EMPTY_OBJECT;
+  options = options ?? Frozen.EMPTY_OBJECT;
   const magic = options.magic ?? [98, 51, 100, 109];
   const version = options.version ?? 1;
   const featuresLength = options.featuresLength ?? 1;
@@ -201,7 +201,7 @@ Cesium3DTilesTester.generateBatchedTileBuffer = function (options) {
 
 Cesium3DTilesTester.generateInstancedTileBuffer = function (options) {
   // Procedurally generate the tile array buffer for testing purposes
-  options = options ?? DefaultValues.EMPTY_OBJECT;
+  options = options ?? Frozen.EMPTY_OBJECT;
   const magic = options.magic ?? [105, 51, 100, 109];
   const version = options.version ?? 1;
 
@@ -288,7 +288,7 @@ Cesium3DTilesTester.generateInstancedTileBuffer = function (options) {
 
 Cesium3DTilesTester.generatePointCloudTileBuffer = function (options) {
   // Procedurally generate the tile array buffer for testing purposes
-  options = options ?? DefaultValues.EMPTY_OBJECT;
+  options = options ?? Frozen.EMPTY_OBJECT;
   const magic = options.magic ?? [112, 110, 116, 115];
   const version = options.version ?? 1;
   let featureTableJson = options.featureTableJson;
@@ -342,10 +342,10 @@ Cesium3DTilesTester.generatePointCloudTileBuffer = function (options) {
 
 Cesium3DTilesTester.generateCompositeTileBuffer = function (options) {
   // Procedurally generate the tile array buffer for testing purposes
-  options = options ?? DefaultValues.EMPTY_OBJECT;
+  options = options ?? Frozen.EMPTY_OBJECT;
   const magic = options.magic ?? [99, 109, 112, 116];
   const version = options.version ?? 1;
-  const tiles = options.tiles ?? DefaultValues.EMPTY_ARRAY;
+  const tiles = options.tiles ?? Frozen.EMPTY_ARRAY;
   const tilesLength = tiles.length;
 
   let i;
@@ -379,7 +379,7 @@ Cesium3DTilesTester.generateCompositeTileBuffer = function (options) {
 
 Cesium3DTilesTester.generateVectorTileBuffer = function (options) {
   // Procedurally generate the tile array buffer for testing purposes
-  options = options ?? DefaultValues.EMPTY_OBJECT;
+  options = options ?? Frozen.EMPTY_OBJECT;
   const magic = options.magic ?? [118, 99, 116, 114];
   const version = options.version ?? 1;
 
@@ -432,7 +432,7 @@ Cesium3DTilesTester.generateVectorTileBuffer = function (options) {
 
 Cesium3DTilesTester.generateGeometryTileBuffer = function (options) {
   // Procedurally generate the tile array buffer for testing purposes
-  options = options ?? DefaultValues.EMPTY_OBJECT;
+  options = options ?? Frozen.EMPTY_OBJECT;
   const magic = options.magic ?? [103, 101, 111, 109];
   const version = options.version ?? 1;
 

Specs/DomEventSimulator.js

@@ -1,7 +1,7 @@
-import { DefaultValues, FeatureDetection } from "@cesium/engine";
+import { Frozen, FeatureDetection } from "@cesium/engine";
 
 function createMouseEvent(type, options) {
-  options = options ?? DefaultValues.EMPTY_OBJECT;
+  options = options ?? Frozen.EMPTY_OBJECT;
   const canBubble = options.canBubble ?? true;
   const cancelable = options.cancelable ?? true;
   const view = options.view ?? window;
@@ -57,7 +57,7 @@ function createModifiersList(ctrlKey, altKey, shiftKey, metaKey) {
 
 // MouseWheelEvent is legacy
 function createMouseWheelEvent(type, options) {
-  options = options ?? DefaultValues.EMPTY_OBJECT;
+  options = options ?? Frozen.EMPTY_OBJECT;
   const canBubble = options.canBubble ?? true;
   const cancelable = options.cancelable ?? true;
   const view = options.view ?? window;
@@ -95,7 +95,7 @@ function createMouseWheelEvent(type, options) {
 }
 
 function createWheelEvent(type, options) {
-  options = options ?? DefaultValues.EMPTY_OBJECT;
+  options = options ?? Frozen.EMPTY_OBJECT;
   const canBubble = options.canBubble ?? true;
   const cancelable = options.cancelable ?? true;
   const view = options.view ?? window;
@@ -165,7 +165,7 @@ function createWheelEvent(type, options) {
 }
 
 function createTouchEvent(type, options) {
-  options = options ?? DefaultValues.EMPTY_OBJECT;
+  options = options ?? Frozen.EMPTY_OBJECT;
   const canBubble = options.canBubble ?? true;
   const cancelable = options.cancelable ?? true;
   const view = options.view ?? window;
@@ -174,15 +174,15 @@ function createTouchEvent(type, options) {
   const event = document.createEvent("UIEvent");
   event.initUIEvent(type, canBubble, cancelable, view, detail);
 
-  event.touches = options.touches ?? DefaultValues.EMPTY_ARRAY;
-  event.targetTouches = options.targetTouches ?? DefaultValues.EMPTY_ARRAY;
-  event.changedTouches = options.changedTouches ?? DefaultValues.EMPTY_ARRAY;
+  event.touches = options.touches ?? Frozen.EMPTY_ARRAY;
+  event.targetTouches = options.targetTouches ?? Frozen.EMPTY_ARRAY;
+  event.changedTouches = options.changedTouches ?? Frozen.EMPTY_ARRAY;
 
   return event;
 }
 
 function createPointerEvent(type, options) {
-  options = options ?? DefaultValues.EMPTY_OBJECT;
+  options = options ?? Frozen.EMPTY_OBJECT;
   let event;
 
   if (FeatureDetection.isInternetExplorer()) {
@@ -277,7 +277,7 @@ function createPointerEvent(type, options) {
 }
 
 function createDeviceOrientationEvent(type, options) {
-  options = options ?? DefaultValues.EMPTY_OBJECT;
+  options = options ?? Frozen.EMPTY_OBJECT;
   const canBubble = options.canBubble ?? true;
   const cancelable = options.cancelable ?? true;
   const alpha = options.alpha ?? 0.0;

Specs/MetadataTester.js

@@ -1,6 +1,6 @@
 import {
   defined,
-  DefaultValues,
+  Frozen,
   DeveloperError,
   FeatureDetection,
   PropertyTable,
@@ -143,7 +143,7 @@ function createProperties(options) {
 }
 
 MetadataTester.createMetadataTable = function (options) {
-  options = options ?? DefaultValues.EMPTY_OBJECT;
+  options = options ?? Frozen.EMPTY_OBJECT;
   const disableBigIntSupport = options.disableBigIntSupport;
   const disableBigInt64ArraySupport = options.disableBigInt64ArraySupport;
   const disableBigUint64ArraySupport = options.disableBigUint64ArraySupport;
@@ -190,7 +190,7 @@ MetadataTester.createMetadataTable = function (options) {
 };
 
 MetadataTester.createPropertyTable = function (options) {
-  options = options ?? DefaultValues.EMPTY_OBJECT;
+  options = options ?? Frozen.EMPTY_OBJECT;
   const disableBigIntSupport = options.disableBigIntSupport;
   const disableBigInt64ArraySupport = options.disableBigInt64ArraySupport;
   const disableBigUint64ArraySupport = options.disableBigUint64ArraySupport;
@@ -245,7 +245,7 @@ MetadataTester.createPropertyTable = function (options) {
 
 // for EXT_structural_metadata
 MetadataTester.createPropertyTables = function (options) {
-  options = options ?? DefaultValues.EMPTY_OBJECT;
+  options = options ?? Frozen.EMPTY_OBJECT;
 
   const propertyTables = [];
   const bufferViews = {};
@@ -277,7 +277,7 @@ MetadataTester.createPropertyTables = function (options) {
 
 // For EXT_feature_metadata
 MetadataTester.createFeatureTables = function (options) {
-  options = options ?? DefaultValues.EMPTY_OBJECT;
+  options = options ?? Frozen.EMPTY_OBJECT;
 
   const featureTables = {};
   const bufferViews = {};
@@ -309,7 +309,7 @@ MetadataTester.createFeatureTables = function (options) {
 };
 
 MetadataTester.createGltf = function (options) {
-  options = options ?? DefaultValues.EMPTY_OBJECT;
+  options = options ?? Frozen.EMPTY_OBJECT;
 
   const propertyTableResults = MetadataTester.createPropertyTables(options);
 

Specs/createCamera.js

@@ -1,6 +1,6 @@
 import {
   Cartesian3,
-  DefaultValues,
+  Frozen,
   defined,
   GeographicProjection,
   Matrix4,
@@ -20,7 +20,7 @@ function MockScene(canvas) {
 }
 
 function createCamera(options) {
-  options = options ?? DefaultValues.EMPTY_OBJECT;
+  options = options ?? Frozen.EMPTY_OBJECT;
 
   const scene = new MockScene(options.canvas);
   const camera = new Camera(scene);

Specs/pollToPromise.js

@@ -1,7 +1,7 @@
-import { DefaultValues, getTimestamp } from "@cesium/engine";
+import { Frozen, getTimestamp } from "@cesium/engine";
 
 function pollToPromise(f, options) {
-  options = options ?? DefaultValues.EMPTY_OBJECT;
+  options = options ?? Frozen.EMPTY_OBJECT;
 
   const pollInterval = options.pollInterval ?? 1;
   const timeout = options.timeout ?? 5000;

Specs/pollWhilePromise.js

@@ -1,7 +1,7 @@
-import { DefaultValues, getTimestamp } from "@cesium/engine";
+import { Frozen, getTimestamp } from "@cesium/engine";
 
 function pollWhilePromise(promise, f, options) {
-  options = options ?? DefaultValues.EMPTY_OBJECT;
+  options = options ?? Frozen.EMPTY_OBJECT;
 
   const pollInterval = options.pollInterval ?? 1;
   const timeout = options.timeout ?? 5000;

packages/engine/Source/Core/ArcGISTiledElevationTerrainProvider.js

@@ -1,7 +1,7 @@
 import Cartesian2 from "./Cartesian2.js";
 import Check from "./Check.js";
 import Credit from "./Credit.js";
-import DefaultValues from "./DefaultValues.js";
+import Frozen from "./Frozen.js";
 import defined from "./defined.js";
 import Ellipsoid from "./Ellipsoid.js";
 import Event from "./Event.js";
@@ -234,7 +234,7 @@ async function requestMetadata(
  * @see TerrainProvider
  */
 function ArcGISTiledElevationTerrainProvider(options) {
-  options = options ?? DefaultValues.EMPTY_OBJECT;
+  options = options ?? Frozen.EMPTY_OBJECT;
 
   this._resource = undefined;
   this._credit = undefined;
@@ -357,7 +357,7 @@ ArcGISTiledElevationTerrainProvider.fromUrl = async function (url, options) {
   Check.defined("url", url);
   //>>includeEnd('debug');
 
-  options = options ?? DefaultValues.EMPTY_OBJECT;
+  options = options ?? Frozen.EMPTY_OBJECT;
 
   url = await Promise.resolve(url);
   let resource = Resource.createIfNeeded(url);

packages/engine/Source/Core/BingMapsGeocoderService.js

@@ -1,6 +1,6 @@
 import Check from "./Check.js";
 import Credit from "./Credit.js";
-import DefaultValues from "./DefaultValues.js";
+import Frozen from "./Frozen.js";
 import Rectangle from "./Rectangle.js";
 import Resource from "./Resource.js";
 import defined from "./defined.js";
@@ -20,7 +20,7 @@ const url = "https://dev.virtualearth.net/REST/v1/Locations";
  * @param {string} [options.culture] A Bing Maps {@link https://docs.microsoft.com/en-us/bingmaps/rest-services/common-parameters-and-types/supported-culture-codes|Culture Code} to return results in a specific culture and language.
  */
 function BingMapsGeocoderService(options) {
-  options = options ?? DefaultValues.EMPTY_OBJECT;
+  options = options ?? Frozen.EMPTY_OBJECT;
   const key = options.key;
   //>>includeStart('debug', pragmas.debug);
   if (!defined(key)) {

packages/engine/Source/Core/BoxGeometry.js

@@ -2,7 +2,7 @@ import BoundingSphere from "./BoundingSphere.js";
 import Cartesian3 from "./Cartesian3.js";
 import Check from "./Check.js";
 import ComponentDatatype from "./ComponentDatatype.js";
-import DefaultValues from "./DefaultValues.js";
+import Frozen from "./Frozen.js";
 import defined from "./defined.js";
 import DeveloperError from "./DeveloperError.js";
 import Geometry from "./Geometry.js";
@@ -40,7 +40,7 @@ const diffScratch = new Cartesian3();
  * const geometry = Cesium.BoxGeometry.createGeometry(box);
  */
 function BoxGeometry(options) {
-  options = options ?? DefaultValues.EMPTY_OBJECT;
+  options = options ?? Frozen.EMPTY_OBJECT;
 
   const min = options.minimum;
   const max = options.maximum;
@@ -88,7 +88,7 @@ function BoxGeometry(options) {
  * @see BoxGeometry.createGeometry
  */
 BoxGeometry.fromDimensions = function (options) {
-  options = options ?? DefaultValues.EMPTY_OBJECT;
+  options = options ?? Frozen.EMPTY_OBJECT;
   const dimensions = options.dimensions;
 
   //>>includeStart('debug', pragmas.debug);