From 697e79e89a4e91ade13e0f497e0a8647d1790567 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?=E1=84=8E=E1=85=AC=E1=84=8C=E1=85=AE=E1=86=AB=E1=84=92?= =?UTF-8?q?=E1=85=A9?= Date: Tue, 2 Apr 2024 15:12:27 +0900 Subject: [PATCH 1/2] =?UTF-8?q?refactor:=20#283=20=EC=9E=91=EC=97=85=20rev?= =?UTF-8?q?ert?= MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit --- .../koin/domain/user/repository/StudentRepository.java | 6 +++--- .../koreatech/koin/domain/user/service/StudentService.java | 4 ++-- 2 files changed, 5 insertions(+), 5 deletions(-) diff --git a/src/main/java/in/koreatech/koin/domain/user/repository/StudentRepository.java b/src/main/java/in/koreatech/koin/domain/user/repository/StudentRepository.java index 0091c0399e..3f45d72a36 100644 --- a/src/main/java/in/koreatech/koin/domain/user/repository/StudentRepository.java +++ b/src/main/java/in/koreatech/koin/domain/user/repository/StudentRepository.java @@ -11,10 +11,10 @@ public interface StudentRepository extends Repository { Student save(Student student); - Optional findByUserId(Long userId); + Optional findById(Long userId); - default Student getByUserId(Long userId) { - return findByUserId(userId) + default Student getById(Long userId) { + return findById(userId) .orElseThrow(() -> UserNotFoundException.withDetail("userId: " + userId)); } } diff --git a/src/main/java/in/koreatech/koin/domain/user/service/StudentService.java b/src/main/java/in/koreatech/koin/domain/user/service/StudentService.java index 3a45572807..5457844a20 100644 --- a/src/main/java/in/koreatech/koin/domain/user/service/StudentService.java +++ b/src/main/java/in/koreatech/koin/domain/user/service/StudentService.java @@ -25,13 +25,13 @@ public class StudentService { private final UserRepository userRepository; public StudentResponse getStudent(Long userId) { - Student student = studentRepository.getByUserId(userId); + Student student = studentRepository.getById(userId); return StudentResponse.from(student); } @Transactional public StudentUpdateResponse updateStudent(Long userId, StudentUpdateRequest request) { - Student student = studentRepository.getByUserId(userId); + Student student = studentRepository.getById(userId); User user = student.getUser(); checkNicknameDuplication(request.nickname()); checkDepartmentValid(request.major()); From 03eabdec4ffd083347309171d2898dbe5df911c5 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?=E1=84=8E=E1=85=AC=E1=84=8C=E1=85=AE=E1=86=AB=E1=84=92?= =?UTF-8?q?=E1=85=A9?= Date: Tue, 2 Apr 2024 15:12:44 +0900 Subject: [PATCH 2/2] =?UTF-8?q?refactor:=20UserIdentity=20Ordinal=EB=A1=9C?= =?UTF-8?q?=20=EC=88=98=EC=A0=95?= MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit --- src/main/java/in/koreatech/koin/domain/user/model/Student.java | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/main/java/in/koreatech/koin/domain/user/model/Student.java b/src/main/java/in/koreatech/koin/domain/user/model/Student.java index 10ba6ed689..6a4b89b859 100644 --- a/src/main/java/in/koreatech/koin/domain/user/model/Student.java +++ b/src/main/java/in/koreatech/koin/domain/user/model/Student.java @@ -37,7 +37,7 @@ public class Student { private String department; @Column(name = "identity") - @Enumerated(EnumType.STRING) + @Enumerated(EnumType.ORDINAL) private UserIdentity userIdentity; @Column(name = "is_graduated")