From 05c0fb167fc8d8549edc8d54dc6aca2bcddd3058 Mon Sep 17 00:00:00 2001
From: JD Francis <jd@audius.co>
Date: Wed, 15 May 2024 11:35:49 -0500
Subject: [PATCH] Refactor addPremiumMetadata to always set download_conditions

---
 .../web/src/common/store/upload/sagaHelpers.ts     | 14 ++++++++++----
 1 file changed, 10 insertions(+), 4 deletions(-)

diff --git a/packages/web/src/common/store/upload/sagaHelpers.ts b/packages/web/src/common/store/upload/sagaHelpers.ts
index 6a5f0d7211c..eb4bffebd2e 100644
--- a/packages/web/src/common/store/upload/sagaHelpers.ts
+++ b/packages/web/src/common/store/upload/sagaHelpers.ts
@@ -127,17 +127,23 @@ export function* addPremiumMetadata<T extends TrackMetadata>(track: T) {
   )
   if (!isUsdcPurchaseEnabled) return track
 
+  // download_conditions could be set separately from stream_conditions, so we check for them first
+  if (isContentUSDCPurchaseGated(track.download_conditions)) {
+    track.download_conditions = yield* call(
+      getUSDCMetadata,
+      track.download_conditions
+    )
+  }
+
   if (isContentUSDCPurchaseGated(track.stream_conditions)) {
     track.stream_conditions = yield* call(
       getUSDCMetadata,
       track.stream_conditions
     )
-  }
-
-  if (isContentUSDCPurchaseGated(track.download_conditions)) {
+    // If stream_conditions are set, download_conditions should always match
     track.download_conditions = yield* call(
       getUSDCMetadata,
-      track.download_conditions
+      track.stream_conditions
     )
   }