From 9b2fcd8ebef005d5f75886be58be5c48d5f3a056 Mon Sep 17 00:00:00 2001 From: Dharit Tantiviramanond Date: Thu, 9 Nov 2023 15:06:06 -0500 Subject: [PATCH] Remove unnecessary hardcoded list of challenges --- .../hooks/useAccountHasClaimableRewards.ts | 29 +++---------------- 1 file changed, 4 insertions(+), 25 deletions(-) diff --git a/packages/common/src/hooks/useAccountHasClaimableRewards.ts b/packages/common/src/hooks/useAccountHasClaimableRewards.ts index b7c8b51297f..eeda7517959 100644 --- a/packages/common/src/hooks/useAccountHasClaimableRewards.ts +++ b/packages/common/src/hooks/useAccountHasClaimableRewards.ts @@ -1,36 +1,15 @@ -import { ChallengeName, ChallengeRewardID } from '../models' +import { ChallengeRewardID } from '../models' import { getOptimisticUserChallenges } from '../store/challenges/selectors' import { useProxySelector } from './useProxySelector' -const validRewardIds: Set = new Set([ - 'track-upload', - 'referrals', - 'ref-v', - 'mobile-install', - 'connect-verified', - 'listen-streak', - 'profile-completion', - 'referred', - 'send-first-tip', - 'first-playlist', - ChallengeName.AudioMatchingSell, - ChallengeName.AudioMatchingBuy -]) - -/** Pulls rewards from remoteconfig */ -const getActiveRewardIds = (challengeRewardsIds: string) => { - if (challengeRewardsIds === null) return [] - const rewards = challengeRewardsIds.split(',') as ChallengeRewardID[] - const activeRewards = rewards.filter((reward) => validRewardIds.has(reward)) - return activeRewards -} - export const useAccountHasClaimableRewards = (challengeRewardsIds: string) => { return useProxySelector( (state) => { const optimisticUserChallenges = getOptimisticUserChallenges(state) - const activeRewardIds = getActiveRewardIds(challengeRewardsIds) + const activeRewardIds = challengeRewardsIds.split( + ',' + ) as ChallengeRewardID[] const activeUserChallenges = Object.values( optimisticUserChallenges ).filter((challenge) => activeRewardIds.includes(challenge.challenge_id))