[pull] main from google:main#30
Merged
Merged
Conversation
* Fix RunConfig docs: correct import path and add missing fields The Python import was documented as `from google.genai.adk import RunConfig, StreamingMode`, but the actual import path in adk-python is `from google.adk.agents.run_config import RunConfig, StreamingMode`. Corrected all four occurrences. Synced the page against https://github.com/google/adk-python/blob/main/src/google/adk/agents/run_config.py: - Added 11 previously undocumented fields to the class definition, the parameter table, and dedicated sections: avatar_config, input_audio_transcription, realtime_input_config, enable_affective_dialog, proactivity, session_resumption, context_window_compression, save_live_blob, tool_thread_pool_config, custom_metadata, get_session_config. - Marked save_input_blobs_as_artifacts as deprecated and pointed readers to SaveFilesAsArtifactsPlugin; removed it from the comprehensive Python example. - Corrected StreamingMode.BIDI description: it is not used by run_async(); bidirectional streaming goes through runner.run_live(). - Fixed output_audio_transcription default in the table (the field uses default_factory=AudioTranscriptionConfig, not None). - Added a ToolThreadPoolConfig example with a GIL note and a GetSessionConfig example. * Rework RunConfig docs from per-field API ref duplication into a use-case-oriented guide with verified multi-language code samples --------- Co-authored-by: Kristopher Overholt <koverholt@google.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See Commits and Changes for more details.
Created by
pull[bot] (v2.0.0-alpha.4)
Can you help keep this open source service alive? 💖 Please sponsor : )
Summary by cubic
Rewrote the RunConfig docs into a use‑case guide with verified Python/TypeScript/Go/Java examples. Corrects the Python import path, clarifies streaming modes, and documents new runtime options for live agents, sessions, and limits.
Refactors
get_session_config,context_window_compression,realtime_input_config,proactivity,enable_affective_dialog,avatar_config,session_resumption,save_live_blob,tool_thread_pool_config,custom_metadata, andinput_audio_transcription.Modalityfrom@google/genai; added API reference links per language.Bug Fixes
from google.adk.agents.run_config import RunConfig, StreamingMode.StreamingMode.BIDIisn’t used byrun_async(); bidirectional streaming goes throughrunner.run_live().save_input_blobs_as_artifactsfrom examples.Written for commit 889e32d. Summary will update on new commits. Review in cubic