CodeRabbit review comments implementation.

Author: tmikula-dev

api.yaml

@@ -89,12 +89,12 @@ paths:
                 items:
                   type: string
 
-  /topics/{topicName}:
+  /topics/{topic_name}:
     get:
       summary: Get schema for a specific topic
       description: Returns the schema for a specified topic using [JSON Schema](https://json-schema.org/).
       parameters:
-        - name: topicName
+        - name: topic_name
           in: path
           required: true
           schema:
@@ -125,7 +125,7 @@ paths:
       security:
         - bearerAuth: []
       parameters:
-        - name: topicName
+        - name: topic_name
           in: path
           required: true
           schema:
@@ -179,7 +179,7 @@ paths:
                   error:
                     type: string
 
-  /stats/{topicName}:
+  /stats/{topic_name}:
     post:
       summary: Query run/job statistics
       description: >
@@ -189,7 +189,7 @@ paths:
       security:
         - bearerAuth: []
       parameters:
-        - name: topicName
+        - name: topic_name
           in: path
           required: true
           schema:

src/handlers/handler_stats.py

@@ -88,13 +88,13 @@ def handle_request(self, event: dict[str, Any]) -> dict[str, Any]:
         cursor = body.get("cursor")
         limit: int = body.get("limit", POSTGRES_DEFAULT_LIMIT)
 
-        if timestamp_start is not None and not isinstance(timestamp_start, int):
+        if timestamp_start is not None and (isinstance(timestamp_start, bool) or not isinstance(timestamp_start, int)):
             return build_error_response(400, "validation", "Field 'timestamp_start' must be an integer (epoch ms).")
-        if timestamp_end is not None and not isinstance(timestamp_end, int):
+        if timestamp_end is not None and (isinstance(timestamp_end, bool) or not isinstance(timestamp_end, int)):
             return build_error_response(400, "validation", "Field 'timestamp_end' must be an integer (epoch ms).")
-        if cursor is not None and not isinstance(cursor, int):
+        if cursor is not None and (isinstance(cursor, bool) or not isinstance(cursor, int)):
             return build_error_response(400, "validation", "Field 'cursor' must be an integer (internal_id).")
-        if not isinstance(limit, int) or limit < 1:
+        if not isinstance(limit, int) or isinstance(limit, bool) or limit < 1:
             return build_error_response(400, "validation", "Field 'limit' must be a positive integer.")
 
         # Execute query
@@ -107,7 +107,7 @@ def handle_request(self, event: dict[str, Any]) -> dict[str, Any]:
             )
         except RuntimeError as exc:
             logger.exception("Stats query failed for topic %s.", topic_name)
-            return build_error_response(500, "database", str(exc))
+            return build_error_response(500, "database", "Stats query failed.")
 
         return {
             "statusCode": 200,

src/writers/writer_postgres.py

@@ -43,7 +43,7 @@ class PsycopgError(Exception):  # type: ignore
 
 class WriterPostgres(Writer):
     """Postgres writer for storing events in PostgreSQL database.
-    Database credentials are loaded from AWS Secrets Manager at initialization.
+    Database credentials are loaded lazily from AWS Secrets Manager on first use.
     """
 
     def __init__(self, config: dict[str, Any]) -> None:

tests/unit/handlers/test_handler_stats.py

@@ -221,6 +221,24 @@ def test_invalid_limit_returns_400(self, handler: HandlerStats) -> None:
 
         assert 400 == response["statusCode"]
 
+    def test_boolean_timestamp_start_returns_400(self, handler: HandlerStats) -> None:
+        """Test that boolean timestamp_start is rejected."""
+        response = handler.handle_request(_make_event(body={"timestamp_start": True}))
+
+        assert 400 == response["statusCode"]
+
+    def test_boolean_cursor_returns_400(self, handler: HandlerStats) -> None:
+        """Test that boolean cursor is rejected."""
+        response = handler.handle_request(_make_event(body={"cursor": False}))
+
+        assert 400 == response["statusCode"]
+
+    def test_boolean_limit_returns_400(self, handler: HandlerStats) -> None:
+        """Test that boolean limit is rejected."""
+        response = handler.handle_request(_make_event(body={"limit": True}))
+
+        assert 400 == response["statusCode"]
+
 
 class TestHandlerStatsErrors:
     """Tests for error handling."""
@@ -235,3 +253,4 @@ def test_database_error_returns_500(self, handler: HandlerStats, mock_reader: Ma
         body = json.loads(response["body"])
         assert False is body["success"]
         assert "database" == body["errors"][0]["type"]
+        assert "Stats query failed." == body["errors"][0]["message"]