-
-
Notifications
You must be signed in to change notification settings - Fork 75
intial ydotool integeration #209
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
3 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,75 @@ | ||
| import { execFile } from "node:child_process" | ||
| import { promisify } from "node:util" | ||
|
|
||
| const execFileAsync = promisify(execFile) | ||
|
|
||
| // Cache the availability of ydotool to avoid repeated checks | ||
| let isYdotoolAvailable: boolean | null = null | ||
| let ydotoolPath: string | null = null | ||
|
|
||
| // Cooldown state for failure retries | ||
| let lastFailureTime = 0 | ||
| const COOLDOWN_MS = 5000 // 5 seconds before retrying | ||
|
|
||
| /** | ||
| * Checks if ydotool is available on the system. | ||
| */ | ||
| export async function checkYdotool(): Promise<boolean> { | ||
| if (isYdotoolAvailable !== null) { | ||
| return isYdotoolAvailable | ||
| } | ||
|
|
||
| const now = Date.now() | ||
| if (now - lastFailureTime < COOLDOWN_MS) { | ||
| return false // Still in cooldown | ||
| } | ||
|
|
||
| try { | ||
| // Suppress error output if not found, we only care if it succeeds or fails | ||
| const { stdout } = await execFileAsync("which", ["ydotool"]) | ||
| ydotoolPath = stdout.trim() | ||
|
imxade marked this conversation as resolved.
|
||
| isYdotoolAvailable = !!ydotoolPath | ||
| if (isYdotoolAvailable) { | ||
| console.log(`[ydotool] Found at ${ydotoolPath}`) | ||
| } | ||
| } catch (err) { | ||
| isYdotoolAvailable = false | ||
| lastFailureTime = now | ||
| console.warn( | ||
| "[ydotool] ydotool is not available, falling back to nut.js for cursor movement.", | ||
| ) | ||
| } | ||
|
|
||
| return isYdotoolAvailable | ||
| } | ||
|
|
||
| /** | ||
| * Moves the mouse cursor relatively using ydotool. | ||
| * | ||
| * @param dx X offset | ||
| * @param dy Y offset | ||
| * @returns true if successful, false otherwise | ||
| */ | ||
| export async function moveRelative(dx: number, dy: number): Promise<boolean> { | ||
| if (!(await checkYdotool()) || !ydotoolPath) { | ||
| return false | ||
| } | ||
|
|
||
| try { | ||
| // ydotool mousemove -x <dx> -y <dy> | ||
| await execFileAsync(ydotoolPath, [ | ||
| "mousemove", | ||
| "-x", | ||
| String(dx), | ||
| "-y", | ||
| String(dy), | ||
| ]) | ||
| return true | ||
| } catch (err) { | ||
| console.error("[ydotool] Error executing mousemove:", err) | ||
| // Enter cooldown instead of permanently disabling | ||
| isYdotoolAvailable = null | ||
| lastFailureTime = Date.now() | ||
| return false | ||
|
coderabbitai[bot] marked this conversation as resolved.
|
||
| } | ||
| } | ||
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.